gh-94438: Add additional cases to mark_stacks with tests#111237
Merged
brandtbucher merged 8 commits intopython:mainfrom Oct 24, 2023
Merged
gh-94438: Add additional cases to mark_stacks with tests#111237brandtbucher merged 8 commits intopython:mainfrom
brandtbucher merged 8 commits intopython:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After reading through #94438, it appeared that there were still outstanding issues with mark_stacks as there was no case that checking for POP_JUMP_IF_NONE and POP_JUMP_IF_NOT_NONE, which could break pdb's jump in 3.11 or higher. This adds these case to the switch statement plus a couple of tests.